Differential D28546

Listen IPv4 instead Any as CALLBACK_URL is hardcoded to 127.0.0.1
Needs RevisionPublic
Actions

Authored by truf on Apr 3 2020, 11:54 PM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Summary

In resources/tomboynotes/o2/o0globals.h callback urls is hardcoded:

const char O2_CALLBACK_URL[] = "http://127.0.0.1:%1/";

for some reason on my machine tomboynotes was listening only IPv6, took some time to troubleshoot
so if there is already only ipv4 localhost callback URL why not listen on IPv4 only
that way we could avoid wierd issues

QHostAddress::AnyIPv4

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Lint Skipped
Unit
Unit Tests Skipped
truf created this revision.Apr 3 2020, 11:54 PM
Restricted Application added a subscriber: kde-pim. · View Herald TranscriptApr 3 2020, 11:54 PM
truf requested review of this revision.Apr 3 2020, 11:54 PM
dvratil requested changes to this revision.Apr 4 2020, 11:51 AM
dvratil added a subscriber: dvratil.

Hmm, should we really listen on the "Any" address? It feels wrong, since we are expecting connection on localhost - so I think listening on QHostAddress::LocalHost might be better...

This revision now requires changes to proceed.Apr 4 2020, 11:51 AM

Revision Contents
Changeset List

PathPackages
Mresources/tomboynotes/o2/o1.cpp (2 lines)

Diff 79255

View Options

resources/tomboynotes/o2/o1.cpp

Loading...