Differential D28539

[Emoji panel] search when the user begins typing
ClosedPublic
Actions

Authored by ngraham on Apr 3 2020, 2:32 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
VDG
Summary

Right now you need to hit Ctrl + F to start searching. This patch additionally makes the
search start as soon as you start typing.

It's a bit slow though, not sure why?

FEATURE: 419716
FIXED-IN: 5.19.0

Test Plan

open emoji panel and start typing

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24676
Build 24694: arc lint + arc unit
ngraham created this revision.Apr 3 2020, 2:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 3 2020, 2:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 3 2020, 2:32 PM
ngraham edited the test plan for this revision. (Show Details)Apr 3 2020, 2:33 PM
apol accepted this revision.Apr 3 2020, 6:35 PM

Fonts are slow...

This revision is now accepted and ready to land.Apr 3 2020, 6:35 PM
ngraham retitled this revision from [Emoji panel] search search when the user begins typing to [Emoji panel] search when the user begins typing.Apr 3 2020, 6:35 PM

Yes, but hitting Ctrl+f and typing results in an instant search, while applying this patch and just typing results in a 3-second lag for me before the view switches and the search begons. It feels like I did something wrong rather than running into some kind of inherent font rendering issue.

ngraham edited the summary of this revision. (Show Details)Apr 15 2020, 3:00 AM
ngraham closed this revision.May 23 2020, 1:04 AM

This landed.

Revision Contents
Changeset List

Diff 79223

View Options

applets/kimpanel/backend/ibus/emojier/ui/CategoryPage.qml

Loading...
View Options

applets/kimpanel/backend/ibus/emojier/ui/emojier.qml

Loading...