Differential D28531

[KNotificationJobUiDelegate] Append "Failed" for error messages
ClosedPublic
Actions

Authored by broulik on Apr 3 2020, 7:56 AM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R289:524bdc640dcc: [KNotificationJobUiDelegate] Append "Failed" for error messages
Summary

Makes the resulting error notification resemble one like a KJobTracker failure as if I had copied a file.

Test Plan
  • Failed to launch an app, got "Launching foo... (Failed)"

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 3 2020, 7:56 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 3 2020, 7:56 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 3 2020, 7:56 AM
broulik retitled this revision from [KNotificationJobUiDelegate] Prepend "Failed" for error messages to [KNotificationJobUiDelegate] Append "Failed" for error messages.Apr 3 2020, 8:32 AM
apol accepted this revision.Apr 3 2020, 10:23 AM
This revision is now accepted and ready to land.Apr 3 2020, 10:23 AM
Closed by commit R289:524bdc640dcc: [KNotificationJobUiDelegate] Append "Failed" for error messages (authored by broulik). · Explain WhyApr 9 2020, 12:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/knotificationjobuidelegate.cpp (7 lines)

Diff 79699

View Options

src/knotificationjobuidelegate.cpp

Loading...