[KMenuEdit] Port QRegExp to QRegularExpression
ClosedPublic

Authored by ahmadsamir on Apr 2 2020, 4:08 PM.

Details

Test Plan
  • Start kmenuedit, create a new sub-menu somewhere, name it t-1
  • Creat a new submenu in the same location and name it t-1 again the submenu is created but named t-2 automatically
  • Copy an existing item to the same location from where you copied it, note the "-number" suffix that's added
  • Drag and drop a .desktop file twice on the same location, note the suffix that's added
  • The createDesktopFile() part, in tree.cpp, strips the name to a base that's then fed to KService::newServicePath(), e.g. "foo-1.desktop" to "foo"

Diff Detail

Repository
R103 KMenu Editor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Apr 2 2020, 4:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 2 2020, 4:08 PM
ahmadsamir requested review of this revision.Apr 2 2020, 4:08 PM
apol accepted this revision.Apr 2 2020, 5:24 PM
apol added a subscriber: apol.

It could make sense for you to test that the names are properly parsed besides just making sure it starts.

This revision is now accepted and ready to land.Apr 2 2020, 5:24 PM
ahmadsamir updated this revision to Diff 79188.Apr 3 2020, 7:10 AM
ahmadsamir edited the test plan for this revision. (Show Details)
ahmadsamir removed a subscriber: apol.

Add proper test plan

This revision was automatically updated to reflect the committed changes.
In D28519#640339, @apol wrote:

It could make sense for you to test that the names are properly parsed besides just making sure it starts.

Done.