Instead use CommandLauncherJob.
Also set desktopFileName for nicer startup feedback
Details
Details
- Reviewers
dfaure mart - Group Reviewers
Plasma - Commits
- R114:a2ebeeb65717: Port Konsole and Kate runners and dataengine away from KToolInvocation
For T12185
- Can launch kate sessions from krunner
- Can launch konsole sessions from krunner
- Can launch konsole sessions from konsole sessions plasmoid
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I kinda feel CommandLauncherJob should have a QString executable, QStringList args constructor so I don't have to escape things myself?
Sounds good, excellent idea. This would simplify the code in many callers. Please add :)
It still needs to support the "QString command" use case though, since that's sometimes what we have as input. Well, at least for KRun::runCommand, but we can keep that public for other use cases I guess (exec lines extracted from desktop/config files, inputted by users etc.).