Port Konsole and Kate runners and dataengine away from KToolInvocation
ClosedPublic

Authored by broulik on Apr 2 2020, 12:02 PM.

Details

Summary

Instead use CommandLauncherJob.
Also set desktopFileName for nicer startup feedback

Test Plan

For T12185

  • Can launch kate sessions from krunner
  • Can launch konsole sessions from krunner
  • Can launch konsole sessions from konsole sessions plasmoid

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 2 2020, 12:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 2 2020, 12:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 2 2020, 12:02 PM
broulik edited the test plan for this revision. (Show Details)Apr 2 2020, 12:05 PM

I kinda feel CommandLauncherJob should have a QString executable, QStringList args constructor so I don't have to escape things myself?

Sounds good, excellent idea. This would simplify the code in many callers. Please add :)

It still needs to support the "QString command" use case though, since that's sometimes what we have as input. Well, at least for KRun::runCommand, but we can keep that public for other use cases I guess (exec lines extracted from desktop/config files, inputted by users etc.).

broulik updated this revision to Diff 79137.Apr 2 2020, 1:51 PM
broulik edited the test plan for this revision. (Show Details)
  • Use new constructor introduced in D28515
mart accepted this revision.Apr 6 2020, 9:21 AM
This revision is now accepted and ready to land.Apr 6 2020, 9:21 AM
This revision was automatically updated to reflect the committed changes.