Differential D28510

[kprocessrunner] Escape hyphen characters in scope names
ClosedPublic
Actions

Authored by davidedmundson on Apr 2 2020, 10:12 AM.

Details

Reviewers
apol
Commits
R241:6fba90325237: [kprocessrunner] Escape hyphen characters in scope names
Summary

Desktop names can be from the set "ASCII letters, digits, dash (U+002D
HYPHEN-MINUS) and underscore (U+005F LOW LINE). "

Hyphen is a special character in systemd units indicating a logical tree
level. We would process drop-ins incorrectly, Specification says they should be escaped.

Test Plan

Ran elf-dissector
systemdcg-ls showed
org.kde.elf\x2ddissector-0dc652e69f5d4557873db10d03517b41.scope

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 2 2020, 10:12 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 2 2020, 10:12 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Apr 2 2020, 10:12 AM
apol accepted this revision.Apr 2 2020, 2:41 PM
This revision is now accepted and ready to land.Apr 2 2020, 2:41 PM
Closed by commit R241:6fba90325237: [kprocessrunner] Escape hyphen characters in scope names (authored by davidedmundson). · Explain WhyApr 3 2020, 11:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/gui/kprocessrunner.cpp (5 lines)

Diff 79202

View Options

src/gui/kprocessrunner.cpp

Loading...