Differential D28466

Added Page element
ClosedPublic
Actions

Authored by niccolove on Mar 31 2020, 2:59 PM.

Details

Reviewers
ngraham
mart
Group Reviewers
Plasma
Maniphest Tasks
T10470: Improve the visuals of tray popups
Commits
R242:8b5e09314162: Added Page element
Summary

Page element was missing. I added it.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
niccolove created this revision.Mar 31 2020, 2:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 31 2020, 2:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
niccolove requested review of this revision.Mar 31 2020, 2:59 PM
davidedmundson added a subscriber: davidedmundson.Mar 31 2020, 3:47 PM
davidedmundson added inline comments.
src/declarativeimports/plasmacomponents3/Page.qml
3

when did you add it?

25

what background?

niccolove updated this revision to Diff 79004.Mar 31 2020, 3:51 PM

Used correct year and implicitWidth/Height code

niccolove marked 2 inline comments as done.Mar 31 2020, 3:52 PM
ngraham added a subscriber: ngraham.Mar 31 2020, 4:12 PM

Could you add some explanation regarding what this is for? Ideally, both in the phab patch and also inline, as API docs.

Also shouldn't this be in PlasmaExtras?

niccolove added a comment.Mar 31 2020, 4:18 PM
In D28466#639011, @ngraham wrote:

Could you add some explanation regarding what this is for? Ideally, both in the phab patch and also inline, as API docs.

Also shouldn't this be in PlasmaExtras?

I'll explain here first to make sure it's correct: from what I was able to understand talking to Marco, plasmacomponents3 are QtQuick components with plasma style. In this case there is not a svg for a page in the desktoptheme, so this effectively just behaves like a normal Page component.

ngraham added a comment.Mar 31 2020, 4:19 PM
In D28466#639018, @niccolove wrote:
In D28466#639011, @ngraham wrote:

Could you add some explanation regarding what this is for? Ideally, both in the phab patch and also inline, as API docs.

Also shouldn't this be in PlasmaExtras?

I'll explain here first to make sure it's correct: from what I was able to understand talking to Marco, plasmacomponents3 are QtQuick components with plasma style. In this case there is not a svg for a page in the desktoptheme, so this effectively just behaves like a normal Page component.

Ah right, yeah. PC3 is indeed correct then. My bad!

ngraham accepted this revision.Mar 31 2020, 5:42 PM

LGTM but make sure @davidedmundson or another Plasma person agrees.

This revision is now accepted and ready to land.Mar 31 2020, 5:42 PM
mart accepted this revision.Apr 3 2020, 10:49 AM
Closed by commit R242:8b5e09314162: Added Page element (authored by niccolove). · Explain WhyApr 3 2020, 3:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79227

View Options

src/declarativeimports/plasmacomponents3/Page.qml

Loading...
View Options

src/declarativeimports/plasmacomponents3/qmldir

Loading...