Let kicker display executable items instead of empty buttons.
ClosedPublic

Authored by ochurlaud on Sep 23 2016, 1:31 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ochurlaud updated this revision to Diff 6896.Sep 23 2016, 1:31 PM
ochurlaud retitled this revision from to Let kicker display executable items instead of empty buttons..
ochurlaud updated this object.
ochurlaud edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptSep 23 2016, 1:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ochurlaud added a reviewer: Plasma.

@broulik remarked that a .desktop file should not define a Exec="" when it is Type=Service.

If we want to respect this, we could split all kcm files in one part which defines the service, and one that defines the Exec line, as a Type=Application instead of this patch.

It might be more work, but it would respect the rules. (and say that Krunner can only execute if it's of type Application).

mart added a subscriber: mart.Sep 23 2016, 1:48 PM

+1 from me (i think kcms with exec line are here to stay)
Eike?

hein requested changes to this revision.Sep 24 2016, 10:09 AM
hein edited edge metadata.
hein added inline comments.
applets/kicker/plugin/recentusagemodel.cpp
175–178

Please check both the type and exec().

This revision now requires changes to proceed.Sep 24 2016, 10:09 AM
ochurlaud updated this revision to Diff 6906.Sep 24 2016, 11:16 AM
ochurlaud edited edge metadata.

Check for type, as asked by Sho

ochurlaud updated this revision to Diff 6909.Sep 24 2016, 12:05 PM
ochurlaud edited edge metadata.

Use !contains() instead of index() == -1

davidedmundson accepted this revision.Sep 24 2016, 12:08 PM
davidedmundson added a reviewer: davidedmundson.
mart accepted this revision.Sep 24 2016, 12:12 PM
mart added a reviewer: mart.
This revision was automatically updated to reflect the committed changes.