This would partially fix https://bugs.kde.org/show_bug.cgi?id=369242
Another patch is required not to show empty elements (in case data() returns QVariant()).
Details
Details
- Reviewers
davidedmundson mart hein - Group Reviewers
Plasma - Commits
- R120:21fca72f03de: Let kicker display executable items instead of empty buttons.
R120:d108387afd2b: Let kicker display executable items instead of empty buttons.
R119:1d2984f8001d: Let kicker display executable items instead of empty buttons.
R119:5c966a42554f: Let kicker display executable items instead of empty buttons.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
@broulik remarked that a .desktop file should not define a Exec="" when it is Type=Service.
If we want to respect this, we could split all kcm files in one part which defines the service, and one that defines the Exec line, as a Type=Application instead of this patch.
It might be more work, but it would respect the rules. (and say that Krunner can only execute if it's of type Application).
applets/kicker/plugin/recentusagemodel.cpp | ||
---|---|---|
175–178 | Please check both the type and exec(). |