Differential D28458

[runners/converter] Skip empty parts when splitting units
ClosedPublic
Actions

Authored by alex on Mar 31 2020, 8:20 AM.

Details

Reviewers
broulik
Commits
R114:6e6c5707d406: [runners/converter] Skip empty parts when splitting units
Summary

Skip empty parts when splitting the units(D27166: Refactor converter runner).
PS: I had to set the locale to german to reproduce this issue,
thats why I didn't noticed it in the first place.

Test Plan

Does not display results for queries like 1/2

Diff Detail

Repository
R114 Plasma Addons
Branch
converter_fix (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24511
Build 24529: arc lint + arc unit
alex created this revision.Mar 31 2020, 8:20 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 31 2020, 8:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alex requested review of this revision.Mar 31 2020, 8:20 AM
broulik accepted this revision.Mar 31 2020, 8:26 AM

Thanks!

This revision is now accepted and ready to land.Mar 31 2020, 8:26 AM
alex added a comment.Mar 31 2020, 10:04 AM

I don't know why but I cant land this patch(arc land --preview looks fine) and the previous commits worked:
fatal: remote error: service not enabled: /kdeplasma-addons

I would be thankful if you could commit this.

ngraham retitled this revision from Bugfix ConverterRunner to Skip empty parts when splitting units.Mar 31 2020, 2:02 PM
ngraham retitled this revision from Skip empty parts when splitting units to [runners/converter] Skip empty parts when splitting units.Mar 31 2020, 2:09 PM
Closed by commit R114:6e6c5707d406: [runners/converter] Skip empty parts when splitting units (authored by alex, committed by ngraham). · Explain WhyMar 31 2020, 2:10 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Mar 31 2020, 2:12 PM

No problem. :)

Revision Contents
Changeset List

Diff 78959

View Options

runners/converter/converterrunner.cpp

Loading...