add dbus interface to the greeter
AbandonedPublic

Authored by bshah on Mar 31 2020, 6:01 AM.

Details

Reviewers
None
Summary

Currently this dbus interface allows the notification server to pass the
notifications, which then are forwarded to greeter theme by calling the
Notify method on the root object.

This is alternative to D28428

Test Plan

tested using mobile greeter

Diff Detail

Repository
R133 KScreenLocker
Branch
bshah/ksld-dbus-notify
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24550
Build 24568: arc lint + arc unit
bshah created this revision.Mar 31 2020, 6:01 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 31 2020, 6:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah requested review of this revision.Mar 31 2020, 6:01 AM

I'd say we go for the simplest solution +++

Given we have MPRIS on here, if we were to do any DBus lockdowns we would almost certainly want to use xdg-dbus-proxy, at which point this would continue to work.

greeter/greeterapp.cpp
141

Register objects before registering a service.

DBus receiving is in another thread so you could hypothetically get a message between the two events.

Doesn't really matter if we lose a notification in this case, but it's a good practice

500

This pattern of fetching and poking the root object of a scene isn't one I like, it's better to expose an object to the view that then has normal signals and slots - but this does follow the convention already here, so I can't really object.

greeter/greeterapp.h
52

You don't need this if you're using an adaptor

bshah marked 2 inline comments as done.Mar 31 2020, 9:16 AM
bshah updated this revision to Diff 78968.Mar 31 2020, 9:16 AM
  • fixup comments mentioned by David
bshah added inline comments.Mar 31 2020, 9:19 AM
greeter/greeterapp.cpp
500

Let's add a todo for future? Once this is done, I do have plan to change the OSD bit to also use greeter directly, instead of wayland protocol bit. That time I can update that.

bshah planned changes to this revision.Mar 31 2020, 9:25 AM

I need to add methods for the communicating the actions back to notification server.

bshah updated this revision to Diff 78978.Mar 31 2020, 11:17 AM
  • proper object instead of QMetaObject invokeMethod
bshah marked 2 inline comments as done.Mar 31 2020, 11:19 AM
bshah updated this revision to Diff 79013.Apr 1 2020, 4:38 AM
  • change signal name, notify caused confusion with notify of QObj
bshah abandoned this revision.Apr 22 2020, 2:48 PM