messagecomposer/autotests/encryptjobtest.cpp
254	Mem leak as it never deleted no ?
messagecomposer/src/job/encryptjob.cpp
127	add missing space before (
messagecomposer/src/job/encryptjob.h
57	Message *skeletonMessage
messagecomposer/src/job/protectedheaders.cpp
70	add missing space before (
134	const auto &header ?
135	const

This revision now requires changes to proceed.Mar 31 2020, 5:16 AM

Address laurents comments and improve the test a little bit.

Harbormaster completed remote builds in B24726: Diff 79292.Apr 4 2020, 1:45 PM

Upload the new patch ;)

Harbormaster completed remote builds in B24729: Diff 79295.Apr 4 2020, 1:58 PM

Add a job chain test.

Harbormaster completed remote builds in B24958: Diff 79663.Apr 8 2020, 6:52 PM

mlaurent requested changes to this revision.Apr 9 2020, 4:47 AM

mlaurent added inline comments.

messagecomposer/autotests/encryptjobtest.cpp
274	endsWith('\n')
messagecomposer/autotests/setupenv.cpp
100	const auto
messagecomposer/src/job/protectedheaders.cpp
134	const auto headers = d->skeletonMessage->headers(); for (const auto &header : headers) { } fix missing space after "for" and '(' too

This revision now requires changes to proceed.Apr 9 2020, 4:47 AM

fixed raised issues.

Harbormaster completed remote builds in B24994: Diff 79734.Apr 9 2020, 8:45 PM

mlaurent accepted this revision.Apr 10 2020, 4:50 AM

This revision is now accepted and ready to land.Apr 10 2020, 4:50 AM

Closed by commit R94:4bfdadca88ba: Implement of "Protected Headers for Cryptographic E-mail". T742 (authored by knauss). · Explain WhyApr 10 2020, 5:49 PM

This revision was automatically updated to reflect the committed changes.

		Path
A	M	messagecomposer/autotests/data/non-protected_headers.mbox (3 lines)
A	M	messagecomposer/autotests/data/protected_headers-non-obvoscate.mbox (6 lines)
A	M	messagecomposer/autotests/data/protected_headers-obvoscate.mbox (16 lines)
M		messagecomposer/autotests/encryptjobtest.h (4 lines)
M		messagecomposer/autotests/encryptjobtest.cpp (132 lines)
M		messagecomposer/autotests/setupenv.h (13 lines)
M		messagecomposer/autotests/setupenv.cpp (35 lines)
M		messagecomposer/src/CMakeLists.txt (1 line)
M		messagecomposer/src/composer/composer.cpp (1 line)
P		messagecomposer/src/job/encryptjob.h (6 lines) Copied to messagecomposer/src/job/protectedheaders.h
M		messagecomposer/src/job/encryptjob.cpp (81 lines)
P		messagecomposer/src/job/protectedheaders.h (38 lines) Copied from messagecomposer/src/job/encryptjob.h
A	M	messagecomposer/src/job/protectedheaders.cpp (167 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78941	33f7fdf		Mar 31 2020, 12:57 AM	★	★
Diff 2	79292	8f428a6	Address laurents comments and improve the test a little bit.	Apr 4 2020, 1:45 PM	★	★
Diff 3	79295	8f428a6	Upload the new patch ;)	Apr 4 2020, 1:58 PM	★	★
Diff 4	79663	d408c93	Add a job chain test.	Apr 8 2020, 6:52 PM	★	★
Diff 5	79734	d3fa256	fixed raised issues.	Apr 9 2020, 8:45 PM	★	★
Diff 6	79782	d3fa256	R94:4bfdadca88ba19783e6e4539100aca553e014902	Apr 9 2020, 8:45 PM	★	★

Implement of "Protected Headers for Cryptographic E-mail". T742
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 79782

messagecomposer/autotests/data/non-protected_headers.mbox

messagecomposer/autotests/data/protected_headers-non-obvoscate.mbox

messagecomposer/autotests/data/protected_headers-obvoscate.mbox

messagecomposer/autotests/encryptjobtest.h

messagecomposer/autotests/encryptjobtest.cpp

messagecomposer/autotests/setupenv.h

messagecomposer/autotests/setupenv.cpp

messagecomposer/src/CMakeLists.txt

messagecomposer/src/composer/composer.cpp

messagecomposer/src/job/encryptjob.h

messagecomposer/src/job/encryptjob.cpp

messagecomposer/src/job/protectedheaders.h

messagecomposer/src/job/protectedheaders.cpp

Implement of "Protected Headers for Cryptographic E-mail". T742ClosedPublicActions