Differential D28447

refactor [messagecomposer]: Replace skeletonJobFinished with lambda function.
ClosedPublic
Actions

Authored by knauss on Mar 31 2020, 12:55 AM.

Details

Reviewers
mlaurent
Commits
R94:d3fa256da606: refactor [messagecomposer]: Replace skeletonJobFinished with lambda function.
Test Plan

run autotests successfully

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss created this revision.Mar 31 2020, 12:55 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 31 2020, 12:55 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss requested review of this revision.Mar 31 2020, 12:55 AM
mlaurent requested changes to this revision.Mar 31 2020, 5:06 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
messagecomposer/src/composer/composer.cpp
274

it seems not releated to this patch no ?

This revision now requires changes to proceed.Mar 31 2020, 5:06 AM
knauss updated this revision to Diff 79285.Apr 4 2020, 12:45 PM

Address laurent's comments.

knauss marked an inline comment as done.Apr 4 2020, 12:45 PM
mlaurent accepted this revision.Apr 9 2020, 4:48 AM
This revision is now accepted and ready to land.Apr 9 2020, 4:48 AM
Closed by commit R94:d3fa256da606: refactor [messagecomposer]: Replace skeletonJobFinished with lambda function. (authored by knauss). · Explain WhyApr 9 2020, 8:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79733

View Options

messagecomposer/src/composer/composer.h

Loading...
View Options

messagecomposer/src/composer/composer.cpp

Loading...