[screenlocker] listen to notifications from the notification server
AbandonedPublic
Actions

Authored by bshah on Mar 30 2020, 10:22 AM.

Details

Reviewers

Summary

This will allow notification manager to forward the notifications that
are meant to be shown on the lockscreen, currently it requires patches
in ksld wayland protocol and greeter to be useful, which is not part of
this patch.

Test Plan

tested with D28427

Diff Detail

Repository

R133 KScreenLocker

Branch

bshah/ksld-notifications

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24460
Build 24478: arc lint + arc unit

bshah created this revision.Mar 30 2020, 10:22 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2020, 10:22 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

bshah requested review of this revision.Mar 30 2020, 10:22 AM

Harbormaster completed remote builds in B24454: Diff 78872.Mar 30 2020, 10:22 AM

nicolasfella added a subscriber: nicolasfella.Mar 30 2020, 11:29 AM

nicolasfella added inline comments.

interface.cpp
213	conding style: & after space

add argument for the notification id in dbus service
add wayland protocol stanza for passing notification data to greeter

Harbormaster completed remote builds in B24460: Diff 78883.Mar 30 2020, 12:09 PM

bshah marked an inline comment as done.Mar 30 2020, 12:10 PM

properly wire up the protocol for ksldapp to greeter

Harbormaster completed remote builds in B24472: Diff 78904.Mar 30 2020, 2:39 PM

We've added a DBus interface to the screensaver host; ksmserver or kwin respectively.
That receives the notification and then using a different API over wayland, sends it to the greeter.
Is that right?

Is so, why this extra complicated route?

This revision now requires changes to proceed.Mar 30 2020, 3:20 PM

bshah mentioned this in D28455: add dbus interface to the greeter.Mar 31 2020, 6:01 AM

Closed in favor of the more simpler version.

Revision Contents
Changeset List

			Path	Packages
M			dbus/org.kde.screensaver.xml (22 lines)
M			interface.h (6 lines)
M			interface.cpp (11 lines)
M			protocols/ksld.xml (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78872	decf7c9		Mar 30 2020, 10:22 AM	★	★
Diff 2	78883	decf7c9	- add argument for the notification id in dbus service	Mar 30 2020, 12:09 PM	★	★
Diff 3	78904	decf7c9	- properly wire up the protocol for ksldapp to greeter	Mar 30 2020, 2:39 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
84da0e7696bd	4879f6215e2b	5b1279448af4	Bhushan Shah	add argument for the notification id in dbus service (Show More…)	Mar 30 2020, 12:06 PM
5b1279448af4	85a0d588fead	decf7c9d4f43	Bhushan Shah	[screenlocker] listen to notifications from the notification server (Show More…)	Mar 30 2020, 10:18 AM