KIO: remove waitForStarted() from the launcher jobs public API
ClosedPublic

Authored by dfaure on Mar 28 2020, 11:07 PM.

Details

Summary

This only exists for KRun. I don't want apps to start using that.
We have to be able to remove waitForStarted() in KF6 so that we can do other
async things before starting the process (like resolving URLs, making async dbus
calls for FUSE stuff etc.)

  • Rename KRun::KRunPrivate to KRunPrivate so that we can declare it as friend in the job classes
  • Move two file-static methods in krun.cpp into the KRunPrivate class so they benefit from this
Test Plan

It builds

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24397
Build 24415: arc lint + arc unit
dfaure created this revision.Mar 28 2020, 11:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 28 2020, 11:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Mar 28 2020, 11:07 PM
broulik accepted this revision.Mar 29 2020, 10:28 AM
This revision is now accepted and ready to land.Mar 29 2020, 10:28 AM
dfaure closed this revision.Mar 29 2020, 10:35 AM