Add support for logging categories
ClosedPublic

Authored by romangg on Mar 28 2020, 10:41 PM.

Details

Summary

Adds category logging to the KScreenLocker daemon/library and the greeter.

Replaces all current uncategorized messages with categorized ones in these
parts.

Test Plan

Tested messages with autotests and QT_LOGGING_RULES="kscreenlocker*=true".

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Mar 28 2020, 10:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 28 2020, 10:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Mar 28 2020, 10:41 PM
romangg added inline comments.Mar 28 2020, 10:42 PM
autotests/CMakeLists.txt
24

Any idea how to reuse the declaration from the top-directory CMake file?

apol added a subscriber: apol.Mar 29 2020, 4:27 PM

Other than that, the patch looks good. +1

autotests/CMakeLists.txt
24

Make sure the include() call is before the add_subdirectory().

That's why we usually put them together on top right under the find_package() together with include(ECMGenerateHeaders).

romangg updated this revision to Diff 78881.Mar 30 2020, 11:51 AM

Include the cpp files

romangg added inline comments.Mar 30 2020, 11:52 AM
autotests/CMakeLists.txt
24

Put the include on top and the other trick was to just include the generated cpp file. Thanks.

apol accepted this revision.Mar 30 2020, 1:48 PM
This revision is now accepted and ready to land.Mar 30 2020, 1:48 PM
This revision was automatically updated to reflect the committed changes.