Differential D28377

Do not ask users if they want to overwrite saved file twice
ClosedPublic
Actions

Authored by yurchor on Mar 28 2020, 2:14 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R206:f15bb39e719b: Do not ask users if they want to overwrite saved file twice
R206:28ab73bcf260: Do not ask users if they want to overwrite saved file twice
Summary

Qt file dialog already asks if user want the file to be overwritten.

Test Plan
  1. Open a message with some link.
  2. Right-click on the link and choose "Save link as..."
  3. Save the file.
  4. Repeat step 2, click "OK".
  5. Confirm the file to be overwritten from Qt dialog.
  6. Without this patch, a new KMail dialog should appear with another proposal to overwrite the file.

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Mar 28 2020, 2:14 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 28 2020, 2:14 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
yurchor requested review of this revision.Mar 28 2020, 2:14 PM
mlaurent accepted this revision.Mar 28 2020, 3:53 PM
This revision is now accepted and ready to land.Mar 28 2020, 3:53 PM
Closed by commit R206:28ab73bcf260: Do not ask users if they want to overwrite saved file twice (authored by yurchor). · Explain WhyMar 28 2020, 3:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmcommands.cpp (17 lines)

Diff 78734

View Options

src/kmcommands.cpp

Loading...