Improve responsiveness when showing single image without thumbnail bar
ClosedPublic

Authored by sandsmark on Mar 28 2020, 1:56 PM.

Details

Summary

Editing an image in a huge folder before this patch is pretty frustrating because there's a ton of (unnecessary) stuff happening in the background.

In this case it is the thumbnail delegates that constantly fetch and convert qmodelindexes to positions to check if they need to update their hover ui, even if the hover ui things are off. Further improvements would be to actually check if the hover stuff is used, but with this patch things seem pretty smooth at least.

Test Plan

Thumbnails work, no more lag when not showing thumbnails, hover ui still work.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sandsmark requested review of this revision.Mar 28 2020, 1:56 PM
sandsmark created this revision.
ngraham accepted this revision.Mar 30 2020, 2:05 PM
ngraham added a subscriber: ngraham.

Stable branch

This revision is now accepted and ready to land.Mar 30 2020, 2:05 PM
This revision was automatically updated to reflect the committed changes.