Differential D28370

Set a better defaultDropAction for dragging
ClosedPublic
Actions

Authored by trmdi on Mar 28 2020, 3:36 AM.

Details

Reviewers
ngraham
Group Reviewers
Dolphin
Commits
R318:4440e961a07a: Set a better defaultDropAction for dragging
Summary

Because we use KIO::DropJob to determine the dropAction, so changing this one does not change anything else except the default cursor from the copy icon to the closed-hand one.

Test Plan

Drag files without holding any modifier key and see the cursor.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trmdi created this revision.Mar 28 2020, 3:36 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 28 2020, 3:36 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
trmdi requested review of this revision.Mar 28 2020, 3:36 AM
ngraham accepted this revision.Mar 30 2020, 12:23 AM

This makes sense to me and it's what Folder View does too.

This revision is now accepted and ready to land.Mar 30 2020, 12:23 AM
Closed by commit R318:4440e961a07a: Set a better defaultDropAction for dragging (authored by trmdi). · Explain WhyMar 30 2020, 2:54 AM
This revision was automatically updated to reflect the committed changes.
trmdi added a comment.EditedSep 6 2020, 3:51 AM
In D28370#676352, @elvisangelaccio wrote:

This caused issues so I reverted it for now.

https://bugs.kde.org/show_bug.cgi?id=425757
https://bugs.kde.org/show_bug.cgi?id=426196

Sorry about that.
For the 1st bug, I tested on VLC, Firefox, Inkscape => it works. No idea why it doesn't work with gnome apps in that bug report.
For the 2nd one, I think this is a Qt bug which has been fixed: https://bugreports.qt.io/browse/QTBUG-82934

Revision Contents
Changeset List

Diff 78829

View Options

src/kitemviews/kitemlistcontroller.cpp

Loading...