[runners/recentdocuments] disable executables or .desktop files
ClosedPublic

Authored by davidedmundson on Mar 27 2020, 11:16 PM.

Details

Summary

It's possible to have a .desktop file in your recent documents list as
you were editing it. Either as a .desktop file or masquerading as
something else.

By default we would process the .desktop file like a .desktop file.

You do get a prompt if the .desktop file is not executable like in
dolphin.

Given we know from context that we're showing recent "Documents" we may
as well turn that behaviour off without risk of ill effects.

BUG: 419310

Test Plan

Created .desktop file (masquerading as something else)
Had it in my recent documents after opening in another format
Loaded the file from krunner. It now opened in my text editor instead of running
the Exec line

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 27 2020, 11:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 27 2020, 11:16 PM
ngraham accepted this revision.Mar 28 2020, 6:21 PM
ngraham added a subscriber: ngraham.

Stable branch?

This revision is now accepted and ready to land.Mar 28 2020, 6:21 PM
This revision was automatically updated to reflect the committed changes.