[ChannelOptionsDialog] Port to QRegularExpression plus some optimisations

Authored by ahmadsamir on Mar 27 2020, 5:33 PM.


  • More const
  • Use range-for
  • Remove some redundant vars that weren't used anywhere
  • Replace QString arg().arg() with QString::arg(string, string), (the latter is more safe to use)
  • Where appropriate, move var declaration/definition to right where they'll be used
Test Plan

make && a quick check with creating a channel on Freenode and setting
modes for it, seems to work well.

Diff Detail

R7 Konversation
l-channel-opt-dlg (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 24343
Build 24361: arc lint + arc unit
ahmadsamir requested review of this revision.Mar 27 2020, 5:33 PM
ahmadsamir created this revision.
psn accepted this revision.Mar 27 2020, 5:46 PM
This revision is now accepted and ready to land.Mar 27 2020, 5:46 PM
This revision was automatically updated to reflect the committed changes.