Fix jpeg save quality
ClosedPublic

Authored by sandsmark on Mar 27 2020, 2:11 PM.

Details

Reviewers
ngraham
Group Reviewers
Gwenview
Commits
R260:67e7b62d4fd3: Fix jpeg save quality
Summary

I got extremely bad quality when editing and saving JPEGs, and apparently didn't it only not initialize the quality when saving it also stored random garbage values in the config files, so they were preserved forever.

So fetch the current value from config initially, and fetch it again when calling save as, in case it changed. Still a bit broken, it won't be reloaded if just saving and it is changed elsewhere, but this is the minimal change that seems to fix the current implementation.

Test Plan

Save jpeg files, it works.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sandsmark requested review of this revision.Mar 27 2020, 2:11 PM
sandsmark created this revision.
ngraham accepted this revision.Mar 27 2020, 2:12 PM
ngraham added a subscriber: ngraham.

Oops.

Commit to the stable branch please! (release/20.04)

This revision is now accepted and ready to land.Mar 27 2020, 2:12 PM
This revision was automatically updated to reflect the committed changes.

You merge the stable branch to master, I guess, so I don't need to push it to master separately?