Fix leaking ThumbnailGenerators
ClosedPublic

Authored by sandsmark on Mar 27 2020, 2:05 PM.

Details

Summary

The logic for deleting ThumbnailGenerators was kind of broken, so fix that.

Not sure if this is the right approach, but it doesn't seem racy (and can't trigger any races), and doesn't leak anymore.

Test Plan

Run with asan and ubsan, open folders with many thumbnails, scroll around.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sandsmark requested review of this revision.Mar 27 2020, 2:05 PM
sandsmark created this revision.
ngraham accepted this revision.Apr 14 2020, 3:26 PM
ngraham added inline comments.
lib/thumbnailprovider/thumbnailprovider.cpp
180

Remove commented-out code

This revision is now accepted and ready to land.Apr 14 2020, 3:26 PM
This revision was automatically updated to reflect the committed changes.