Refactor of OverlaySheet
AcceptedPublic

Authored by mart on Wed, Mar 25, 4:43 PM.

Details

Reviewers
ngraham
Group Reviewers
Kirigami
Summary

Rework OverlaySheet to remove some sizing hacks that made ListView and GridView
not work well, fix some appearance issues with the new scrollbar, make it easier
to dismiss sheets via swipe.
the internal flickabe is never interactive, flicking is only managed by an
external flickable that manages both normal flicking and dismissal swipe

Test Plan

Before:


After:

Diff Detail

Repository
R169 Kirigami
Branch
mart/overlaysheetrefactor2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24310
Build 24328: arc lint + arc unit
mart created this revision.Wed, Mar 25, 4:43 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptWed, Mar 25, 4:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Wed, Mar 25, 4:43 PM
mart edited the test plan for this revision. (Show Details)Wed, Mar 25, 4:47 PM

FWIW this needs a rebase as there were apparently some changes to OverlaySheet on master since this was branched.

mart updated this revision to Diff 78532.Thu, Mar 26, 10:34 AM
  • Merge branch 'master' into mart/overlaysheetrefactor2
anthonyfieroni added inline comments.
src/controls/templates/OverlaySheet.qml
5–7

Keep SPDX.

mart updated this revision to Diff 78542.Thu, Mar 26, 11:49 AM
  • better response to window resizes

Generally much nicer looking. I found one visual issue: when I switch from touchpad scrolling to touchscreen scrolling, the close button in the corner gets overlapped by the content area since the scroll track gets narrower.

src/controls/OverlaySheet.qml
22–23

Remove commented code

src/controls/templates/OverlaySheet.qml
4

Is this intentional?

266

I thought we weren't supposed to multiply duration values. :) is the new veryLongDuration not long enough? do we need superDuperLongDuration?

351

what's this +1 for?

mart updated this revision to Diff 78616.Fri, Mar 27, 9:27 AM
mart marked 4 inline comments as done.
  • adress comments
mart added a comment.Fri, Mar 27, 9:30 AM

Generally much nicer looking. I found one visual issue: when I switch from touchpad scrolling to touchscreen scrolling, the close button in the corner gets overlapped by the content area since the scroll track gets narrower.

in general the x button when there is not an header is giving some problems, uglyness and complications.
I'm thinking to maybe *always* show the header with separator line and all even if empty when there is a close button...

src/controls/templates/OverlaySheet.qml
4

ah, sorry no derives from conflicts resolution

266

was a debug thing forgotten in, sorry :)

351

to make the view always scrolling, or the swipe to dismiss can get broken

In D28289#635601, @mart wrote:

I'm thinking to maybe *always* show the header with separator line and all even if empty when there is a close button...

Makes sense to me, yeah.

ngraham accepted this revision.Fri, Mar 27, 1:44 PM
This revision is now accepted and ready to land.Fri, Mar 27, 1:44 PM