Differential D28288

[QML] Correctly watch for unregistration
ClosedPublic
Actions

Authored by bruns on Mar 25 2020, 4:25 PM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
Baloo
Commits
R293:26e9b4afd7dd: [QML] Correctly watch for unregistration
Summary

We wont get the serviceUnregistered signal if only the
WatchForRegistration flag is set.

Remove the unused service name from the balooStarted method.

Test Plan
  1. start kinfocenter
  2. balooctl disable

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Mar 25 2020, 4:25 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 25 2020, 4:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 25 2020, 4:25 PM
davidedmundson accepted this revision.Mar 25 2020, 4:38 PM
This revision is now accepted and ready to land.Mar 25 2020, 4:38 PM
Closed by commit R293:26e9b4afd7dd: [QML] Correctly watch for unregistration (authored by bruns). · Explain WhyMar 25 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 78480