Differential D28288

[QML] Correctly watch for unregistration
ClosedPublic
Actions

Authored by bruns on Mar 25 2020, 4:25 PM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
Baloo
Commits
R293:26e9b4afd7dd: [QML] Correctly watch for unregistration
Summary

We wont get the serviceUnregistered signal if only the
WatchForRegistration flag is set.

Remove the unused service name from the balooStarted method.

Test Plan
  1. start kinfocenter
  2. balooctl disable

Diff Detail

Repository
R293 Baloo
Branch
config_rework
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24221
Build 24239: arc lint + arc unit
bruns created this revision.Mar 25 2020, 4:25 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 25 2020, 4:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 25 2020, 4:25 PM
davidedmundson accepted this revision.Mar 25 2020, 4:38 PM
This revision is now accepted and ready to land.Mar 25 2020, 4:38 PM
Closed by commit R293:26e9b4afd7dd: [QML] Correctly watch for unregistration (authored by bruns). · Explain WhyMar 25 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78476

View Options

src/qml/experimental/monitor.h

Loading...
View Options

src/qml/experimental/monitor.cpp

Loading...