Polish SwipeListItem
ClosedPublic

Authored by apol on Sep 21 2016, 3:58 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:f90a5ca65f04: Polish SwipeListItem
Summary

Make sure we don't have 2 different code paths for contentItem
initialization as one of them had a different parent.
Set a negative z to the background, to make sure it's below the contents.
Don't let the padding go over the handle, this way the contens will be
able to fit to the space

Test Plan

Looks the same on kirigamigallery
Now we can make it look okay in discover, as some neon sources get really long.

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 6855.Sep 21 2016, 3:58 PM
apol retitled this revision from to Polish SwipeListItem.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptSep 21 2016, 3:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added inline comments.Sep 21 2016, 4:03 PM
src/controls/templates/SwipeListItem.qml
362 ↗(On Diff #6855)

what's the rationale for this?

apol updated this revision to Diff 6856.Sep 21 2016, 4:20 PM

Reduce magic numbers

apol marked an inline comment as done.Sep 21 2016, 4:20 PM
apol added inline comments.
src/controls/templates/SwipeListItem.qml
362 ↗(On Diff #6855)

Good point, fixed.

mart accepted this revision.Sep 21 2016, 4:48 PM
mart edited edge metadata.
This revision is now accepted and ready to land.Sep 21 2016, 4:48 PM
This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.