skip over supposed network shares that aren't
ClosedPublic

Authored by sitter on Mar 25 2020, 11:13 AM.

Details

Summary

we explicitly request listFromType(Solid::DeviceInterface::NetworkShare)
but apparently still can get devices that aren't actually of that type.
add an explicit type check to guard against bogus shares coming out of
listFromType.

CCBUG: 419220

Test Plan

mount an overlay (I am guessing that's what the problem with kubuntu is), observe no crash on init

Diff Detail

Repository
R102 KInfoCenter
Branch
smb-type-check
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24205
Build 24223: arc lint + arc unit
sitter created this revision.Mar 25 2020, 11:13 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 25 2020, 11:13 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Mar 25 2020, 11:13 AM
ngraham accepted this revision.Mar 25 2020, 4:07 PM

Whoops!

This revision is now accepted and ready to land.Mar 25 2020, 4:07 PM
This revision was automatically updated to reflect the committed changes.