Differential D28275

skip over supposed network shares that aren't
ClosedPublic
Actions

Authored by sitter on Mar 25 2020, 11:13 AM.

Details

Reviewers
ngraham
Commits
R102:4847c9e2fed2: skip over supposed network shares that aren't
Summary

we explicitly request listFromType(Solid::DeviceInterface::NetworkShare)
but apparently still can get devices that aren't actually of that type.
add an explicit type check to guard against bogus shares coming out of
listFromType.

CCBUG: 419220

Test Plan

mount an overlay (I am guessing that's what the problem with kubuntu is), observe no crash on init

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 25 2020, 11:13 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 25 2020, 11:13 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Mar 25 2020, 11:13 AM
ngraham accepted this revision.Mar 25 2020, 4:07 PM

Whoops!

This revision is now accepted and ready to land.Mar 25 2020, 4:07 PM
Closed by commit R102:4847c9e2fed2: skip over supposed network shares that aren't (authored by sitter). · Explain WhyMar 25 2020, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MModules/samba/smbmountmodel.cpp (5 lines)

Diff 78472

View Options

Modules/samba/smbmountmodel.cpp

Loading...