Previously we copied frames first to a temporary QImage and then to PipeWire buffer. This shouldn't be
necessary as we can copy frames directly to PipeWire buffers which should be much more effecient.
BUG: 419209
Details
Details
- Reviewers
zzag - Group Reviewers
Plasma - Commits
- R838:45092f756316: Avoid copying buffer twice
R838:f6e559702cf5: Avoid copying buffer twice
Diff Detail
Diff Detail
- Repository
- R838 Flatpak Support: KDE Portal for XDG Desktop
- Branch
- screensharing-improvements
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24201 Build 24219: arc lint + arc unit
| src/screencaststream.cpp | ||
|---|---|---|
| 549–563 | Do we actually need an fbo? | |
| src/screencaststream.cpp | ||
|---|---|---|
| 549–563 | The entire framebuffer is superfluous, it is never used. glGetTexImage() reads from the currently bound texture, which in this case is "texture" since you bind it at line 546. | |
| src/screencaststream.cpp | ||
|---|---|---|
| 549–563 | The fbo is gone 8a2286317edf91017a4854814340c48c4552fafe | |