Differential D28270

[Colors KCM] Also save colors when active scheme was edited
ClosedPublic
Actions

Authored by broulik on Mar 25 2020, 8:48 AM.

Details

Reviewers
meven
Group Reviewers
Plasma
Commits
R119:d0f673d0e92b: [Colors KCM] Also save colors when active scheme was edited
Summary

I fixed the case that the "Apply" button wasn't enabled when the selected scheme didn't change but was edited by introducing the m_activeSchemeEdited variable.
However, I didn't actually have it save in this case...

CCBUG: 419168

Test Plan

5.18

  • Changing color schemes still works
  • Changed color scheme, applied it, edited it, applied again and my changes were reflected

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 25 2020, 8:48 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 25 2020, 8:48 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 25 2020, 8:48 AM
broulik edited the summary of this revision. (Show Details)
crossi added a subscriber: crossi.Mar 25 2020, 9:02 AM
meven accepted this revision.Mar 25 2020, 9:39 AM
This revision is now accepted and ready to land.Mar 25 2020, 9:39 AM
Closed by commit R119:d0f673d0e92b: [Colors KCM] Also save colors when active scheme was edited (authored by broulik). · Explain WhyMar 25 2020, 9:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/colors/colors.cpp (2 lines)

Diff 78431

View Options

kcms/colors/colors.cpp

Loading...