KDesktopFileActions: port from KRun::run to KIO::ApplicationLauncherJob
AcceptedPublic

Authored by dfaure on Wed, Mar 25, 12:29 AM.

Details

Summary

Remove KService::Ptr parameter from ApplicationLauncherJob, the
KServiceAction is now sufficient.

Test Plan

dolphin, RMB, "Checkout from a repository..." (requires kdesvn) still works

Diff Detail

Repository
R241 KIO
Branch
kdesktopfileactions
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24362
Build 24380: arc lint + arc unit
dfaure requested review of this revision.Wed, Mar 25, 12:29 AM
dfaure created this revision.
apol accepted this revision.Wed, Mar 25, 3:42 AM

Change looks good.

The advantage here is that it's not blocking, right?

This revision is now accepted and ready to land.Wed, Mar 25, 3:42 AM

Exactly.

The downside is that it's more verbose, but the benefits are that it's non-blocking, and that the job class is in KioGui (no QtWidgets dependency). Doesn't matter for this code here, but it'll be good for QML apps who don't want dialog boxes on error.

(and it's better API because we can add setters, instead of ending up with the 4 overloads in krun.h due to adding parameters one at a time...)

dfaure updated this revision to Diff 78710.Fri, Mar 27, 10:42 PM
dfaure edited the summary of this revision. (Show Details)

Rebase on D28367, remove KService::Ptr arg

Restricted Application added a project: Frameworks. · View Herald TranscriptFri, Mar 27, 10:42 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript