KIO: rename ProcessLauncherJob to ApplicationLauncherJob
ClosedPublic
Actions

Authored by dfaure on Mar 24 2020, 10:11 PM.

Details

Reviewers

davidedmundson
broulik

Maniphest Tasks

T11549: KIO: remove unneeded QWidget dependencies to set parent windows or display errors

Commits

R241:f0d3f37b4871: KIO: rename ProcessLauncherJob to ApplicationLauncherJob

Summary

Initially I thought it could do the job both for applications (running a
desktop file) and commands (running a shell command) but it's better API
to separate the two things.

Test Plan

make && ctest

Diff Detail

Repository

R241 KIO

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24185
Build 24203: arc lint + arc unit

dfaure created this revision.Mar 24 2020, 10:11 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 24 2020, 10:11 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

dfaure requested review of this revision.Mar 24 2020, 10:11 PM

Harbormaster completed remote builds in B24185: Diff 78414.Mar 24 2020, 10:11 PM

davidedmundson accepted this revision.Mar 24 2020, 10:15 PM

This revision is now accepted and ready to land.Mar 24 2020, 10:15 PM

dfaure closed this revision.Mar 24 2020, 10:17 PM

dfaure added a task: T11549: KIO: remove unneeded QWidget dependencies to set parent windows or display errors.Apr 26 2020, 1:52 PM

Revision Contents
Changeset List

			Path	Packages
M			autotests/CMakeLists.txt (2 lines)
V			autotests/{applicationlauncherjobtest.h ← processlauncherjobtest.h} (8 lines)
V			autotests/{applicationlauncherjobtest.cpp ← processlauncherjobtest.cpp} (38 lines)
V			autotests/{processlauncherjobtest.h → applicationlauncherjobtest.h}
V			autotests/{processlauncherjobtest.cpp → applicationlauncherjobtest.cpp}
M			src/gui/CMakeLists.txt (4 lines)
V			src/gui/{applicationlauncherjob.h ← processlauncherjob.h} (22 lines)
V			src/gui/{applicationlauncherjob.cpp ← processlauncherjob.cpp} (32 lines)
M			src/gui/kprocessrunner.cpp (8 lines)
M			src/gui/kprocessrunner_p.h (4 lines)
V			src/gui/{processlauncherjob.h → applicationlauncherjob.h}
V			src/gui/{processlauncherjob.cpp → applicationlauncherjob.cpp}
M			src/widgets/krun.h (2 lines)
M			src/widgets/krun.cpp (10 lines)