[applets/analog-clock] Optional minute hand
Needs ReviewPublic

Authored by aloiseau on Tue, Mar 24, 9:57 PM.

Details

Reviewers
kossebau
Group Reviewers
VDG
Plasma
Summary

Add a configuration option to hide minute hand, the same way second hand can already be hidden.

Those two options are independent, letting user hide minute hand alone.

Clock refresh interval is not modified. It still refreshes every 30 seconds when second hand is hidden, even when hour hand is the only visible one. Having this interval computed from both hiddable hands would make its computation less readable for a minor CPU benefit.

Test Plan
  • Add an Analog Clock to your Plasma wallpaper
  • Go to its setting
  • Deselect new "Show minute hand" option
  • Apply

Minute hand is then hidden from Analog Clock widget.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
aloiseau created this revision.Tue, Mar 24, 9:57 PM
Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. · View Herald TranscriptTue, Mar 24, 9:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
aloiseau requested review of this revision.Tue, Mar 24, 9:57 PM
ngraham edited reviewers, added: VDG, Plasma; removed: Plasma: Workspaces.Tue, Mar 24, 10:01 PM
ngraham added a subscriber: ngraham.

Thanks for the patch, Anthony!

Technical comment: you need to update the kcfg file too, to add a definition of the new option.

Conceptual/UI comment: do you think you could explain the use case for showing an analog clock without a minute hand? I don't think I've ever seen any real-world analog clocks without minute hands.

kossebau resigned from this revision.Tue, Mar 24, 10:05 PM

Resigning, due to currently not having time for Plasma development.

Thanks Nathaniel for your feedbacks.

About your technical comment, I can not find a kcfg file in this applet to simply extend. I will have a closer look to existing kcfg files and create one for analog clock (next weekend I guess)

About the conceptual comment, you are right: clocks without minute hand are not common :)
I have a real one since few years after minute hand gets broken and removed. I finally found the result very ergonomic: faster to read and accurate enough, less disturbing / "attractive" (no need to take a look at it every five minutes).
This is more common when it comes to watches, under the name "slow watches" which features a single hand for a full-day 24-hour circle (mid-day on top and mid-night on bottom). Since I have no doubt about the morning or the evening, I find the halfway with a 12-hours circle still useful and use it daily.

Maybe in the future I will make a proposal for a more real slow clock option (24-hours circle) if someone find it useful.

I can not find a kcfg file in this applet to simply extend

In applets it's the config.xml you edited, so from a technical POV patch is good. Not sure this option is very useful, however.

I can not find a kcfg file in this applet to simply extend

In applets it's the config.xml you edited, so from a technical POV patch is good. Not sure this option is very useful, however.

Ok for the technical POV, thanks. I very understand the usefulness question such option can raise, letting the community integrating it or not.