Differential D28259

[applets/systemtray] Default value for ItemLoader.source
ClosedPublic
Actions

Authored by kmaterka on Mar 24 2020, 8:44 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma: Workspaces
Plasma
Commits
R120:5b99315f75f9: [applets/systemtray] Default value for ItemLoader.source
Summary

When none of the valid conditions are met, function should return default value for ItemLoader source. If not, error is printed in logs.

Test Plan

No warning about undefined value for url

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kmaterka created this revision.Mar 24 2020, 8:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 24 2020, 8:44 PM
kmaterka requested review of this revision.Mar 24 2020, 8:44 PM
ngraham accepted this revision.Mar 24 2020, 8:56 PM
This revision is now accepted and ready to land.Mar 24 2020, 8:56 PM
Closed by commit R120:5b99315f75f9: [applets/systemtray] Default value for ItemLoader.source (authored by kmaterka). · Explain WhyMar 24 2020, 9:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78408

View Options

applets/systemtray/package/contents/ui/items/ItemLoader.qml

Loading...