Differential D28255

Use Qt::endl instead of the deprecated ::endl
ClosedPublic
Actions

Authored by heikobecker on Mar 24 2020, 7:40 PM.

Details

Reviewers
aacid
Commits
R368:56ab7a29941e: Drop unnecessary and deprecated endl
Summary

It was deprecated with Qt 5.15.

Depends on D28254.

Test Plan

Builds

Diff Detail

Repository
R368 RSIBreak
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24176
Build 24194: arc lint + arc unit
heikobecker requested review of this revision.Mar 24 2020, 7:40 PM
heikobecker created this revision.
aacid added a comment.Mar 24 2020, 10:56 PM

the endl is really not needed though, is it? i mean

qWarning() << "Folder does not exist or is not readable: " << folder;

already adds a newline at the end, doesn't it?

heikobecker updated this revision to Diff 78491.Mar 25 2020, 7:19 PM

Removed the endl

heikobecker added a comment.Mar 25 2020, 7:20 PM
In D28255#633992, @aacid wrote:

the endl is really not needed though, is it? i mean

qWarning() << "Folder does not exist or is not readable: " << folder;

already adds a newline at the end, doesn't it?

Doh, of course it does. Thanks.

aacid accepted this revision.Mar 25 2020, 10:21 PM
This revision is now accepted and ready to land.Mar 25 2020, 10:21 PM
Closed by commit R368:56ab7a29941e: Drop unnecessary and deprecated endl (authored by heikobecker). · Explain WhyMar 26 2020, 7:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/slideshoweffect.cpp (2 lines)

Diff 78396

View Options

src/slideshoweffect.cpp

Loading...