Use another icon for the user feedback KCModule
Needs RevisionPublic

Authored by heikobecker on Mar 24 2020, 6:16 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Summary

It's the same that plasma, discover and kate use and a bit more
telling than the current one.

Test Plan

Builds, runs and new icon appears

Diff Detail

Repository
R201 Akregator
Branch
release/20.04
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24168
Build 24186: arc lint + arc unit
heikobecker created this revision.Mar 24 2020, 6:16 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 24 2020, 6:16 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
heikobecker requested review of this revision.Mar 24 2020, 6:16 PM
mlaurent requested changes to this revision.Mar 24 2020, 9:46 PM
mlaurent added a subscriber: mlaurent.

same as other review

This revision now requires changes to proceed.Mar 24 2020, 9:46 PM

Well, I'd argue that a) the preferences-desktop-locale icon provides a visual clue what the entry is about and b) is consistent with other applications by KDE.

+1, If this is the icon that other KDE apps went for Feedback settings, we should stay consistent with the rest of KDE

It is, e.g. Plasma (systemsettings) and Kate: