special character shown in warning dialog
Needs ReviewPublic

Authored by allknow on Mar 24 2020, 2:23 PM.

Details

Reviewers
jachin
drosca
Summary

warning dialog with special character

STEPS TO REPRODUCE

  1. Open some tabs
  2. right click over one of them - click "close others"

OBSERVED RESULT

The dialog shows the "\n" character

Diff Detail

Repository
R875 Falkon
Branch
daan (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24150
Build 24168: arc lint + arc unit
allknow created this revision.Mar 24 2020, 2:23 PM
Restricted Application added a project: Falkon. · View Herald TranscriptMar 24 2020, 2:23 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
allknow requested review of this revision.Mar 24 2020, 2:23 PM
jachin accepted this revision.Mar 24 2020, 10:19 PM
jachin added a subscriber: jachin.

https://forum.qt.io/topic/66191/new-line-n-doesn-t-work
As like this article, maybe dialog.setText(tr("...")) messages are translated in C type character type.
'\r\n' also would be works.
And checked with build source.

This revision is now accepted and ready to land.Mar 24 2020, 10:19 PM
drosca requested changes to this revision.Mar 25 2020, 6:18 AM
drosca added a subscriber: drosca.

It should be <br/> instead.

This revision now requires changes to proceed.Mar 25 2020, 6:18 AM
allknow updated this revision to Diff 78447.EditedMar 25 2020, 1:16 PM

Okay I fixed. thank you

  • Merge branch 'allknow' into daan
abogical added inline comments.
src/lib/app/browserwindow.cpp
1499

I don't think you're supposed to change this line. This will result in always warning you even if you told it to skip the warning next time.

jachin added inline comments.Mar 30 2020, 10:48 PM
src/lib/app/browserwindow.cpp
1499

It looks like for test. It is needed to recover.

allknow updated this revision to Diff 78939.Mar 30 2020, 11:22 PM
  • I fixed "if"