Stop multiplying duration values
ClosedPublic
Actions

Authored by ngraham on Mar 24 2020, 2:16 PM.

Details

Reviewers

None

Group Reviewers

VDG
Plasma

Commits

R119:f3bbc0ba0e34: Stop multiplying duration values

Summary

After D28144, some animations are now too long because they were inappropriately
multiplying a duration value. That's no longer necessary, so let's remove the
multiplication.

Depends on D28144

Test Plan

Various things that were a bit too slow before feel just right now

Diff Detail

Repository

R119 Plasma Desktop

Branch

use-standard-duration-values (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24148
Build 24166: arc lint + arc unit

ngraham created this revision.Mar 24 2020, 2:16 PM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 24 2020, 2:16 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ngraham requested review of this revision.Mar 24 2020, 2:16 PM

Harbormaster completed remote builds in B24148: Diff 78359.Mar 24 2020, 2:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2020, 2:45 AM

Closed by commit R119:f3bbc0ba0e34: Stop multiplying duration values (authored by ngraham). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			applets/taskmanager/package/contents/ui/Task.qml (2 lines)
M			applets/taskmanager/package/contents/ui/TaskList.qml (2 lines)
M			desktoppackage/contents/configuration/PanelConfiguration.qml (4 lines)
M			desktoppackage/contents/explorer/WidgetExplorer.qml (6 lines)
M			toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78359	38a874a		Mar 24 2020, 2:16 PM	★	★
Diff 2	79363	d7213a1	R119:f3bbc0ba0e34ea1b34b106228c02d85865ed904a	Apr 5 2020, 2:45 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
e3a16f30e45b	bd1a64a70f8c	38a874ab82aa	Nate Graham	Stop multiplying duration values (Show More…)	Mar 24 2020, 2:15 PM

Status	Author	Revision
Closed	ngraham	D28034 [Applet] Port to ExpandableListItem
Closed	ngraham	D28035 [Applet] Port to ExpandableListItem
Closed	ngraham	D28036 [Applet] Port to ExpandableListItem
Closed	ngraham	D28037 [Applet] Port to ExpandableListItem
Abandoned	ngraham	D28321 [applets/devicenotifier] Port to ExpandableListItem
Closed	ngraham	D28033 Create ExpandableListItem
Closed	ngraham	D28238 Stop multiplying duration values
Closed	ngraham	D28239 Stop multiplying duration values
Closed	ngraham	D28144 Make animation durations consistent with Kirigami values