Differential D28237

Improvement in sublevel counting in gletters game
ClosedPublic
Actions

Authored by matorix on Mar 24 2020, 2:12 PM.

Details

Reviewers
timotheegiet
jjazeix
Group Reviewers
GCompris
Summary

The count of the subLevel near the bottom right drops back to 1/maxSubLevel upon completing the last subLevel before the level ends.

To improve it, the count is increased only if it is less than the maxSubLevel and set to 1 when a new level begins.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
matorix created this revision.Mar 24 2020, 2:12 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 24 2020, 2:12 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
matorix requested review of this revision.Mar 24 2020, 2:12 PM
timotheegiet requested changes to this revision.EditedMar 24 2020, 4:16 PM
timotheegiet added a subscriber: timotheegiet.

The patch itself looks fine, however I would prefer to fix this issue the other way for those activities.
That is: use the score as an actual score counter, so make it start at 0 instead of 1.

This revision now requires changes to proceed.Mar 24 2020, 4:16 PM
matorix updated this revision to Diff 78400.Mar 24 2020, 8:14 PM

Updated the changes to start the score counter from 0 rather than 1 upto maxSubLevel

jjazeix accepted this revision.Mar 25 2020, 8:04 AM
jjazeix added a subscriber: jjazeix.

good for me, can you provide a username in the form of "FirstName LastName <email>" so I can attribute you the commit please?

matorix added a comment.Mar 25 2020, 8:10 AM

Abhay Kaushik <abhay.gyanbharati@gmail.com>

jjazeix added a comment.Mar 25 2020, 8:13 AM

Thank you!
First commit: https://commits.kde.org/gcompris/aba7f13b9a74ea07514b371ffd74104e2f73435e
I can't close the diff until @timotheegiet accepts the changes, I'll let him do it when he can

timotheegiet accepted this revision.Mar 25 2020, 1:10 PM

Good, thanks!

This revision is now accepted and ready to land.Mar 25 2020, 1:10 PM
timotheegiet closed this revision.Mar 25 2020, 1:10 PM

Revision Contents
Changeset List

Diff 78400

View Options

src/activities/gletters/gletters.js

Loading...