Differential D28234

Use SyntaxHighlighter for highlighting
ClosedPublic
Actions

Authored by apol on Mar 24 2020, 1:58 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R871:f304e0185fb8: Use SyntaxHighlighter for highlighting

Summary

The code is especially fiddly and complex. Using this we can on the
other hand leverage other parts of our system.

Test Plan

Used, will upload screenshot

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol created this revision.Mar 24 2020, 1:58 PM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 24 2020, 1:58 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested review of this revision.Mar 24 2020, 1:58 PM

Harbormaster completed remote builds in B24143: Diff 78354.Mar 24 2020, 1:58 PM

I love it!

src/backtracewidget.cpp
230	Ugh that's awkward.

This revision is now accepted and ready to land.Mar 25 2020, 12:52 PM

Closed by commit R871:f304e0185fb8: Use SyntaxHighlighter for highlighting (authored by apol). · Explain WhyMar 25 2020, 1:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/CMakeLists.txt (3 lines)
M			src/backtracewidget.h (6 lines)
M			src/backtracewidget.cpp (21 lines)
D	M		src/gdbhighlighter.h (45 lines)
D	M		src/gdbhighlighter.cpp (138 lines)

Diff 78446

CMakeLists.txt

Loading...

src/CMakeLists.txt

Loading...

src/backtracewidget.h

Loading...

src/backtracewidget.cpp

Loading...

src/gdbhighlighter.h

Loading...

src/gdbhighlighter.cpp

Loading...