[Device Notifier] Only ever pop up if device is visible in the list
ClosedPublic

Authored by broulik on Sep 20 2016, 7:20 PM.

Details

Summary

When a device notification arrives, such as "you can now safely unmount" or "failed to unmount" device notifier would unconditionally open showing an empty list.
Since we now show device notifications only connected to the device they're about, it makes no sense to expand it for invisible devices. Applications where mounting or unmounting can fail for non-removable devices, like Dolphin, already show the error message within the UI anyway, making the popup redundant.

BUG: 368894
FIXED-IN: 5.8.0

Test Plan
  • plugged in USB key, still got popup
  • unmounted USB key from Dolphin, devicenotifier opened, telling me I could safely remove it now
  • tried to unmount / from Dolphin, got a "not authorized" error in Dolphin and no longer got an empty device notifier popup

Didn't actually test the snappy usecase described in the bug report.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6839.Sep 20 2016, 7:20 PM
broulik retitled this revision from to [Device Notifier] Only ever pop up if device is visible in the list.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, sitter.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 20 2016, 7:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Sep 20 2016, 8:00 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Sep 20 2016, 8:00 PM
sitter accepted this revision.Sep 21 2016, 8:16 AM
sitter edited edge metadata.

lgtm. and it works \o/

This revision was automatically updated to reflect the committed changes.