diff --git a/src/backends/maxima/maximacompletionobject.cpp b/src/backends/maxima/maximacompletionobject.cpp --- a/src/backends/maxima/maximacompletionobject.cpp +++ b/src/backends/maxima/maximacompletionobject.cpp @@ -61,7 +61,7 @@ const QString prefix = command(); QStringList prefixCompletion; - for (const QString str : allCompletions) + for (const QString& str : allCompletions) if (str.startsWith(prefix)) prefixCompletion << str; diff --git a/src/backends/python/pythonserver.cpp b/src/backends/python/pythonserver.cpp --- a/src/backends/python/pythonserver.cpp +++ b/src/backends/python/pythonserver.cpp @@ -175,7 +175,7 @@ #elif PY_MAJOR_VERSION == 2 "except ImportError: \n" #endif - " pass \n", NULL + " pass \n", nullptr ); PyRun_SimpleString("__tmp_globals__ = globals()"); @@ -220,7 +220,7 @@ #elif PY_MAJOR_VERSION == 2 "except ImportError: \n" #endif - " pass \n", NULL + " pass \n", nullptr ); diff --git a/src/backends/scilab/scilabexpression.cpp b/src/backends/scilab/scilabexpression.cpp --- a/src/backends/scilab/scilabexpression.cpp +++ b/src/backends/scilab/scilabexpression.cpp @@ -86,7 +86,7 @@ qDebug() << "output: " << output; const QStringList lines = output.split(QLatin1String("\n")); bool isPrefixLines = true; - for (const QString line : lines) + for (const QString& line : lines) { if (isPrefixLines && line.isEmpty()) continue; diff --git a/src/lib/defaultvariablemodel.cpp b/src/lib/defaultvariablemodel.cpp --- a/src/lib/defaultvariablemodel.cpp +++ b/src/lib/defaultvariablemodel.cpp @@ -201,7 +201,7 @@ beginResetModel(); QStringList names; - for (const Variable var: d->variables) + for (const Variable& var: d->variables) names.append(var.name); d->variables.clear(); @@ -251,7 +251,7 @@ // Handle added vars const int size = d->variables.size(); - for (const Variable newvar : newVars) + for (const Variable& newvar : newVars) { bool found = false; for (int i = 0; i < size; i++) @@ -337,7 +337,7 @@ { Q_D(const DefaultVariableModel); QStringList names; - for (const Variable var: d->variables) + for (const Variable& var: d->variables) names << var.name; return names; }