Differential D28216

[VirtualDesktopInfo] Connect to rowsChanged singal
ClosedPublic
Actions

Authored by broulik on Mar 23 2020, 10:38 AM.

Details

Reviewers
hein
davidedmundson
Group Reviewers
Plasma
Commits
R120:bf28d5d2b4f4: [VirtualDesktopInfo] Connect to rowsChanged singal
Summary

Rather than relying on KWin to have reconfigured, which isn't the case when merely changing the number of rows.

BUG: 408783
FIXED-IN: 5.18.4

Test Plan
  • Changed number of virtual desktops without adding or removing a desktop → pager updated reliably now

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 23 2020, 10:38 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 23 2020, 10:38 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 23 2020, 10:38 AM
ngraham added a subscriber: ngraham.Mar 23 2020, 3:01 PM

+1, makes logical sense.

davidedmundson accepted this revision.Mar 23 2020, 9:17 PM
This revision is now accepted and ready to land.Mar 23 2020, 9:17 PM
Closed by commit R120:bf28d5d2b4f4: [VirtualDesktopInfo] Connect to rowsChanged singal (authored by broulik). · Explain WhyMar 24 2020, 8:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78337

View Options

libtaskmanager/virtualdesktopinfo.cpp

Loading...