Differential D28202

[FileIndexerConfig] Replace config QString,bool pair with dedicated class
ClosedPublic
Actions

Authored by bruns on Mar 22 2020, 1:42 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Commits
R293:7aacb80b23cc: [FileIndexerConfig] Replace config QString,bool pair with dedicated class
Summary

entry.path/entry.isIncluded is more readable than entry.first/enty.second.

Also replace the homegrown insertSort with std::lower_bound + insert.

Test Plan

ctest -R fileindexerconfigtest

Diff Detail

Repository
R293 Baloo
Branch
submit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24062
Build 24080: arc lint + arc unit
bruns created this revision.Mar 22 2020, 1:42 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 22 2020, 1:42 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 22 2020, 1:42 PM
ngraham accepted this revision.Mar 25 2020, 4:26 PM
This revision is now accepted and ready to land.Mar 25 2020, 4:26 PM
Closed by commit R293:7aacb80b23cc: [FileIndexerConfig] Replace config QString,bool pair with dedicated class (authored by bruns). · Explain WhyMar 25 2020, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78225

View Options

src/file/fileindexerconfig.h

Loading...
View Options

src/file/fileindexerconfig.cpp

Loading...