Enable wrapping of error messages which use KMessageWidget
ClosedPublic

Authored by develoot on Sun, Mar 22, 12:49 PM.

Details

Summary

Error messages should be shown to users no matter how much long it is.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
develoot created this revision.Sun, Mar 22, 12:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Mar 22, 12:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
develoot requested review of this revision.Sun, Mar 22, 12:49 PM
ngraham added a subscriber: ngraham.

Thanks for the patch! I wonder if it makes sense to set this on the widget itself, as a sensible default. You're probably going to want to word-wrap more often than you aren't.

davidedmundson accepted this revision.Sun, Mar 22, 10:21 PM
davidedmundson added a subscriber: davidedmundson.

I wonder if it makes sense to set this on the widget itself, as a sensible default.

No.

Not because it's a better or worse default, but because making a behavioural change in released public API would retroactively break any few places where we didn't want to word wrap.

No code adds

setFoo(theDocumentedDefaultValue)

This revision is now accepted and ready to land.Sun, Mar 22, 10:21 PM

I wonder if it makes sense to set this on the widget itself, as a sensible default.

No.

Not because it's a better or worse default, but because making a behavioural change in released public API would retroactively break any few places where we didn't want to word wrap.

No code adds

setFoo(theDocumentedDefaultValue)

Gotcha. Would that be something we can revisit for KF6?

Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information?

develoot added a comment.EditedFri, Mar 27, 3:34 PM

Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information?

My email address is develoot@gmail.com. thanks.
Is there anyway to provide email address automatically?

Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information?

My email address is develoot@gmail.com. thanks.
Is there anyway to provide email address automatically?

Yeah, if you set up the arc command-line tool and use that to submit patches, your email address will be preserved in the patch.

Thanks for the patch! May it be the first of many. :)

This revision was automatically updated to reflect the committed changes.