The code still compiles.
Details
Details
- Reviewers
dfaure - Group Reviewers
Frameworks - Commits
- R241:1d644f8f2eb5: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Nice.
clang-format can't be configured to add missing braces, and to have a max line length?
Comment Actions
Nope, I'd have had to use clang-format (which requires a "compilation server", I read some docs, searched online, tried, then read more docs; found that it took me about half an hour and I still couldn't get it to work (it replaced all of two occurrences and then barfed), I realised it would have taken me 10 minutes to do it by hand, and get on with what's left of my life, which is what I did).
and to have a max line length?
I used a .clang-format copied from clang-format.cmake from extra-cmake-modules, which has "ColumnLimit: 240", but that apparently leads to really long lines... why I didn't tweak the number? I forgot :D