The effectiveStatus parameter was passed as a copy, use proper binding.
Details
Details
- Reviewers
ngraham broulik davidedmundson apol - Group Reviewers
Plasma: Workspaces Plasma - Commits
- R120:17153c4ae204: [applet/systemtray] Use model binding instead of copy
No visible impact
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24027 Build 24045: arc lint + arc unit
Comment Actions
Without this effectiveStatus never changes. Right now it works by happy coincidence - Item is simple destroyed and created in a different, as a side effect new value of effectiveStatus is used.
This change tries to fix my mistake introduced in D26992. I used QML Loader incorrectly... :(
Anyway, I changed it a little bin, please check now.
applets/systemtray/package/contents/ui/items/AbstractItem.qml | ||
---|---|---|
36–37 | You can simplify this to model.status || PlasmaCore.Types.UnknownStatus |
applets/systemtray/package/contents/ui/items/AbstractItem.qml | ||
---|---|---|
36–37 | Done |