It failed for me, and for FreeBSD on CI.
I guess the Linux CI has it all on the same partition, so the moving
across partition case isn't really tested there.
See explanations in the code comment.
Details
Details
Now jobtest passes locally
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24025 Build 24043: arc lint + arc unit
Comment Actions
I confirm that the test gets fixed.
Also the change makes sense.
It seems to me that both else branches end the same. From list = ... it can be moved out, no?
Comment Actions
It was failing locally for me too, both when I had /tmp as tmpfs and when I changed it to be a regular dir on /; /home is a separate partition on my system. So I didn't understand how the test passed on the CI.
FTR, I build KIO on a regular mechanical/spinning HDD, but / and /home are on an SSD. Maybe that's why? the test wants two separate partitions on the same desk? that doesn't make sense though...
Comment Actions
Because on the CI (which is a LXC container), /home isn't a separate partition.
So the tests for "moving between different partitions" are actually testing (again) moving on the same partition, on CI, because there is just one partition.
FTR, I build KIO on a regular mechanical/spinning HDD, but / and /home are on an SSD. Maybe that's why? the test wants two separate partitions on the same desk? that doesn't make sense though...
Not sure what you mean by desk, but I hope the above explains the reason why the test was passing on CI and failing for most of us locally.
Comment Actions
Oops, I meant disk.
That makes sense; most of us would have /home on a separate partition.