[Dialog] Use `ShadowedRectangle`
ClosedPublic
Actions

Authored by broulik on Mar 20 2020, 8:23 AM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R858:eecb8f6402e8: [Dialog] Use `ShadowedRectangle`

Summary

Instead of expensive DropShadow layer.

Test Plan

I only just now found a place where it's actually being used to make sure it still looks the same :)
Before:

After:

(Looks like the border color slightly changed? :0)

Repository

R858 Qt Quick Controls 2: Desktop Style

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Mar 20 2020, 8:23 AM

broulik edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Mar 20 2020, 9:43 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			org.kde.desktop/Dialog.qml (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78071			Mar 20 2020, 8:22 AM	★	★
Diff 2	78075	b738ebb	R858:eecb8f6402e831cc93d6fba2d2cccfdc0a9248cd	Mar 20 2020, 9:59 AM	★	★