Fixed problems with synchronizations of preset selection widgets
ClosedPublic

Authored by dkazakov on Sep 19 2016, 8:58 PM.

Details

Summary
  1. Now the selector has *no* selection if the currently active preset is not present in the filtered list of presets
  2. Clicking on the currently selected preset now either resets it, or does nothing depending on the "Save tweaks..." option value.
  3. All the three preset selectors are now synchronized
  4. The selector correctly shown the "dirty" mark right after you changed any property of the preset.
Test Plan
  1. Check sanity of the current selection in all the three preset selectors. They should be sane and synchronized.
  2. Switching the current tag should keep the selection correct (no selection is a valid state when the active preset is not present in the current tag)
  3. (!) Check if Brush Selector, Texture Selector, Pattern and Gradient popups still work correctly! They use the same codebase :(

Ref T3473

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dkazakov updated this revision to Diff 6822.Sep 19 2016, 8:58 PM
dkazakov retitled this revision from to Fixed problems with synchronizations of preset selection widgets.
dkazakov updated this object.
dkazakov edited the test plan for this revision. (Show Details)
dkazakov added reviewers: Krita, timotheegiet.
This revision was automatically updated to reflect the committed changes.
dkazakov reopened this revision.Sep 21 2016, 1:18 PM

The commit pushed into a branch, so it still needs a review

timotheegiet accepted this revision.Sep 23 2016, 11:57 AM
timotheegiet edited edge metadata.

All tests passed ok for me.
-Selected preset is well sync evervwhere
-no issues with tags
-all other selector/popup working fine

and the bug about closing the preset editor is fixed.

This revision is now accepted and ready to land.Sep 23 2016, 11:57 AM
This revision was automatically updated to reflect the committed changes.